Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add status in geo area #1537

Merged
merged 1 commit into from
Dec 5, 2024
Merged

Add status in geo area #1537

merged 1 commit into from
Dec 5, 2024

Conversation

sudan45
Copy link
Contributor

@sudan45 sudan45 commented Oct 23, 2024

Mention related users here if any.

This PR doesn't introduce any:

  • temporary files, auto-generated files or secret keys
  • n+1 queries
  • flake8 issues
  • print
  • typos
  • unwanted comments

This PR contains valid:

  • tests
  • permission checks (tests here too)
  • translations

@sudan45 sudan45 marked this pull request as draft October 23, 2024 05:15
@sudan45 sudan45 marked this pull request as ready for review November 7, 2024 05:51
susilnem
susilnem requested changes Nov 7, 2024
View reviewed changes
Copy link
Member

@susilnem susilnem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor changes

apps/geo/models.py Outdated Show resolved Hide resolved
apps/geo/models.py Outdated Show resolved Hide resolved
apps/geo/tasks.py Outdated Show resolved Hide resolved
@sudan45 sudan45 requested a review from susilnem November 11, 2024 04:42
@sudan45 sudan45 force-pushed the fix/geo-area-failure-status-trigger branch from 8604dc2 to 1387f5f Compare November 19, 2024 11:11
@shreeyash07 shreeyash07 mentioned this pull request Dec 3, 2024
Merged
11 tasks
@AdityaKhatri AdityaKhatri force-pushed the fix/geo-area-failure-status-trigger branch from 70e5991 to 776e3e6 Compare December 4, 2024 05:13
@sudan45 sudan45 force-pushed the fix/geo-area-failure-status-trigger branch 3 times, most recently from 2d1e66f to 3b4dc37 Compare December 4, 2024 11:38
susilnem
susilnem approved these changes Dec 5, 2024
View reviewed changes
Copy link
Member

@susilnem susilnem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sudan45 sudan45 force-pushed the fix/geo-area-failure-status-trigger branch from 3b4dc37 to 6032a27 Compare December 5, 2024 04:08
@subinasr subinasr force-pushed the fix/geo-area-failure-status-trigger branch from 9791709 to 08e25cb Compare December 5, 2024 08:25
@sudan45 sudan45 force-pushed the fix/geo-area-failure-status-trigger branch from 08e25cb to 42c5648 Compare December 5, 2024 08:39
Rup-Narayan-Rajbanshi
Rup-Narayan-Rajbanshi requested changes Dec 5, 2024
View reviewed changes
Copy link
Contributor

@Rup-Narayan-Rajbanshi Rup-Narayan-Rajbanshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor changes.

apps/geo/tasks.py Show resolved Hide resolved
@AdityaKhatri AdityaKhatri merged commit b265ccd into develop Dec 5, 2024
9 checks passed
@AdityaKhatri AdityaKhatri deleted the fix/geo-area-failure-status-trigger branch December 5, 2024 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@susilnem susilnem susilnem approved these changes

@Rup-Narayan-Rajbanshi Rup-Narayan-Rajbanshi Rup-Narayan-Rajbanshi approved these changes

@AdityaKhatri AdityaKhatri AdityaKhatri approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sudan45 @AdityaKhatri @Rup-Narayan-Rajbanshi @susilnem