Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCR filter #1526

Merged
merged 1 commit into from
Dec 5, 2024
Merged

OCR filter #1526

merged 1 commit into from
Dec 5, 2024

Conversation

sudan45
Copy link
Contributor

@sudan45 sudan45 commented Aug 30, 2024

Implement GraphQL filters for LeadPreviewAttachment by type and excluding specific IDs.

This PR doesn't introduce any:

  • temporary files, auto-generated files or secret keys
  • n+1 queries
  • flake8 issues
  • print
  • typos
  • unwanted comments

This PR contains valid:

  • tests
  • permission checks (tests here too)
  • translations

@sudan45 sudan45 changed the title Add field in lead attachment filter OCR filter f Aug 30, 2024
@sudan45 sudan45 changed the title OCR filter f OCR filter Aug 30, 2024
@AdityaKhatri AdityaKhatri requested a review from thenav56 October 1, 2024 05:33
@AdityaKhatri AdityaKhatri self-assigned this Oct 1, 2024
@sudan45 sudan45 force-pushed the fix/add-field-on-leadattachment-filter branch from c2e53e4 to 320df2b Compare November 22, 2024 05:58
@AdityaKhatri AdityaKhatri force-pushed the fix/add-field-on-leadattachment-filter branch from 320df2b to 3890637 Compare November 22, 2024 10:03
@sudan45 sudan45 force-pushed the fix/add-field-on-leadattachment-filter branch from df70f7c to 88afdb2 Compare December 5, 2024 05:07
Copy link

codecov bot commented Dec 5, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 4 lines in your changes missing coverage. Please review.

Project coverage is 79.73%. Comparing base (4d7ee5d) to head (88afdb2).
Report is 13 commits behind head on develop.

Files with missing lines Patch % Lines
apps/lead/filter_set.py 33.33% 4 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1526      +/-   ##
===========================================
+ Coverage    79.63%   79.73%   +0.10%     
===========================================
  Files          464      464              
  Lines        30076    30142      +66     
  Branches      3379     3385       +6     
===========================================
+ Hits         23952    24035      +83     
+ Misses        6124     6107      -17     
Flag Coverage Δ
?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AdityaKhatri AdityaKhatri force-pushed the fix/add-field-on-leadattachment-filter branch from 88afdb2 to da3d461 Compare December 5, 2024 05:19
@sudan45 sudan45 force-pushed the fix/add-field-on-leadattachment-filter branch from da3d461 to 5394b1a Compare December 5, 2024 06:20
@sudan45 sudan45 force-pushed the fix/add-field-on-leadattachment-filter branch from 5394b1a to 9d48089 Compare December 5, 2024 06:40
@AdityaKhatri AdityaKhatri merged commit 1dd8a6c into develop Dec 5, 2024
8 of 9 checks passed
@AdityaKhatri AdityaKhatri deleted the fix/add-field-on-leadattachment-filter branch December 5, 2024 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants