Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/update viz setting and widgets #1478

Merged
merged 6 commits into from
Jun 13, 2024

Conversation

sudan45
Copy link
Contributor

@sudan45 sudan45 commented Apr 10, 2024

Addresses:

This PR includes changes from

This PR doesn't introduce any:

  • temporary files, auto-generated files or secret keys
  • n+1 queries
  • flake8 issues
  • print
  • typos
  • unwanted comments

This PR contains valid:

  • tests
  • permission checks (tests here too)
  • translations

Copy link
Member

@thenav56 thenav56 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. We need more check for the migration.

apps/analysis_framework/migrations/0041_widget_mapping.py Outdated Show resolved Hide resolved
apps/analysis_framework/migrations/0041_widget_mapping.py Outdated Show resolved Hide resolved
@sudan45 sudan45 force-pushed the feature/update-viz-setting-and-widgets branch 6 times, most recently from c970942 to ab9b672 Compare May 7, 2024 08:44
@subinasr subinasr requested a review from thenav56 May 24, 2024 08:30
@sudan45 sudan45 assigned sudan45, AdityaKhatri and subinasr and unassigned sudan45 May 29, 2024
@sudan45
Copy link
Contributor Author

sudan45 commented May 29, 2024

@AdityaKhatri dai and @subinasr lets test together on alpha 1 server

@sudan45 sudan45 force-pushed the feature/update-viz-setting-and-widgets branch from 7e3997e to 1df5e23 Compare June 10, 2024 04:48
@sudan45 sudan45 force-pushed the feature/update-viz-setting-and-widgets branch from 1df5e23 to 7669a56 Compare June 13, 2024 10:44
@subinasr subinasr merged commit 279227d into develop Jun 13, 2024
9 checks passed
@subinasr subinasr deleted the feature/update-viz-setting-and-widgets branch June 13, 2024 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants