Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement graphql mutation node for Clone Analysis framework #1477

Merged
merged 5 commits into from
Aug 12, 2024
Merged

Implement graphql mutation node for Clone Analysis framework #1477

merged 5 commits into from
Aug 12, 2024

Conversation

susilnem
Copy link
Member

@susilnem susilnem commented Apr 9, 2024 •
edited
Loading

Addresses

Changes

  • Add mutation for clone analysis framework
  • Add Separate serializer for the cloning

Mention related users here if any.

This PR doesn't introduce any:

  • temporary files, auto-generated files or secret keys
  • n+1 queries
  • flake8 issues
  • print
  • typos
  • unwanted comments

This PR contains valid:

  • tests
  • permission checks (tests here too)
  • translations

@susilnem susilnem self-assigned this Apr 9, 2024
@susilnem susilnem changed the base branch from develop to project/rest-to-graphql April 9, 2024 10:19
@susilnem susilnem marked this pull request as ready for review April 10, 2024 07:51
@susilnem susilnem requested review from thenav56, Rup-Narayan-Rajbanshi and sudan45 and removed request for thenav56 April 10, 2024 07:51
Rup-Narayan-Rajbanshi
Rup-Narayan-Rajbanshi reviewed Apr 11, 2024
View reviewed changes
Copy link
Contributor

@Rup-Narayan-Rajbanshi Rup-Narayan-Rajbanshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just some minor code formatting.

apps/analysis_framework/serializers.py Outdated Show resolved Hide resolved
apps/analysis_framework/serializers.py Outdated Show resolved Hide resolved
@subinasr subinasr mentioned this pull request May 15, 2024
Merged
11 tasks
@subinasr subinasr force-pushed the feature/clone-analysis-framework branch from adf76b5 to 324556c Compare May 17, 2024 04:46
@AdityaKhatri AdityaKhatri changed the base branch from project/rest-to-graphql to develop May 17, 2024 04:52
thenav56
thenav56 requested changes May 30, 2024
View reviewed changes
Copy link
Member

@thenav56 thenav56 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Few changes required

apps/analysis_framework/serializers.py Outdated Show resolved Hide resolved
apps/analysis_framework/serializers.py Outdated Show resolved Hide resolved
apps/analysis_framework/serializers.py Outdated Show resolved Hide resolved
apps/analysis_framework/serializers.py Outdated Show resolved Hide resolved
apps/analysis_framework/serializers.py Outdated Show resolved Hide resolved
apps/analysis_framework/tests/test_mutations.py Show resolved Hide resolved
apps/analysis_framework/tests/test_mutations.py Outdated Show resolved Hide resolved
@susilnem susilnem force-pushed the feature/clone-analysis-framework branch from dbb61e3 to e951e78 Compare May 31, 2024 03:47
@susilnem susilnem requested a review from thenav56 May 31, 2024 04:03
thenav56
thenav56 requested changes Jun 5, 2024
View reviewed changes
apps/analysis_framework/serializers.py Outdated Show resolved Hide resolved
@susilnem susilnem force-pushed the feature/clone-analysis-framework branch from e951e78 to 3ab4e9e Compare June 5, 2024 09:51
@susilnem susilnem requested a review from thenav56 June 5, 2024 10:23
@susilnem susilnem force-pushed the feature/clone-analysis-framework branch from 3ab4e9e to 04f4957 Compare June 13, 2024 08:32
@susilnem susilnem requested review from thenav56 and sudan45 and removed request for sudan45 and thenav56 June 13, 2024 08:50
@susilnem susilnem assigned AdityaKhatri and unassigned susilnem Jun 13, 2024
@AdityaKhatri AdityaKhatri force-pushed the feature/clone-analysis-framework branch from 04f4957 to 0adfe5f Compare July 16, 2024 04:25
thenav56
thenav56 requested changes Jul 19, 2024
View reviewed changes
Copy link
Member

@thenav56 thenav56 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's do some clean-ups

apps/analysis_framework/serializers.py Outdated Show resolved Hide resolved
apps/analysis_framework/serializers.py Show resolved Hide resolved
apps/analysis_framework/serializers.py Outdated Show resolved Hide resolved
@susilnem susilnem force-pushed the feature/clone-analysis-framework branch 2 times, most recently from 4e26d85 to f7896e9 Compare July 22, 2024 05:36
@sudan45
Copy link
Contributor

sudan45 commented Jul 22, 2024

Looks Good

@susilnem susilnem requested a review from thenav56 July 22, 2024 08:58
thenav56
thenav56 requested changes Jul 22, 2024
View reviewed changes
Copy link
Member

@thenav56 thenav56 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost done.

apps/analysis_framework/serializers.py Outdated Show resolved Hide resolved
@susilnem susilnem force-pushed the feature/clone-analysis-framework branch from f7896e9 to 677631e Compare July 22, 2024 14:56
@subinasr subinasr force-pushed the feature/clone-analysis-framework branch from 677631e to 21fa23e Compare July 24, 2024 08:54
@AdityaKhatri AdityaKhatri force-pushed the feature/clone-analysis-framework branch from 21fa23e to 8254eed Compare August 9, 2024 05:09
@susilnem susilnem force-pushed the feature/clone-analysis-framework branch from 8254eed to d4a0456 Compare August 12, 2024 05:17
@AdityaKhatri AdityaKhatri merged commit 0d2fa7d into develop Aug 12, 2024
9 checks passed
@AdityaKhatri AdityaKhatri deleted the feature/clone-analysis-framework branch August 12, 2024 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sudan45 sudan45 sudan45 approved these changes

@thenav56 thenav56 thenav56 approved these changes

@Rup-Narayan-Rajbanshi Rup-Narayan-Rajbanshi Rup-Narayan-Rajbanshi left review comments

Assignees

@AdityaKhatri AdityaKhatri

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@susilnem @sudan45 @thenav56 @Rup-Narayan-Rajbanshi @AdityaKhatri