Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Lead's isAssessment & hasAssessment in EntryFilter #1406

Merged
merged 3 commits into from
Apr 4, 2024
Merged

Add Lead's isAssessment & hasAssessment in EntryFilter #1406

merged 3 commits into from
Apr 4, 2024

Conversation

thenav56
Copy link
Member

@thenav56 thenav56 commented Jan 2, 2024 •
edited
Loading

Addresses

Changes

Add new filters in EntryFilter

  • leadIsAssessment
  • leadHasAssessment
  • Fix typo

This PR doesn't introduce any:

  • temporary files, auto-generated files or secret keys
  • n+1 queries
  • flake8 issues
  • print
  • typos
  • unwanted comments

This PR contains valid:

  • tests
  • permission checks (tests here too)
  • translations

thenav56
thenav56 commented Jan 2, 2024
View reviewed changes
apps/entry/filter_set.py Outdated Show resolved Hide resolved
@thenav56 thenav56 marked this pull request as ready for review January 2, 2024 07:48
@thenav56 thenav56 force-pushed the feature/lead-additional-filters branch from 645a508 to bcc7ceb Compare January 30, 2024 06:24
Rup-Narayan-Rajbanshi
Rup-Narayan-Rajbanshi reviewed Jan 30, 2024
View reviewed changes
Copy link
Contributor

@Rup-Narayan-Rajbanshi Rup-Narayan-Rajbanshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@subinasr Let me update old assessment into new assessment_registry in filter.

@Rup-Narayan-Rajbanshi Rup-Narayan-Rajbanshi force-pushed the feature/lead-additional-filters branch 3 times, most recently from f02a591 to 8a7fd5b Compare January 31, 2024 08:57
@thenav56 thenav56 force-pushed the feature/lead-additional-filters branch from 8a7fd5b to 23242b9 Compare February 5, 2024 05:05
@Rup-Narayan-Rajbanshi Rup-Narayan-Rajbanshi force-pushed the feature/lead-additional-filters branch from 86d53c0 to 141515a Compare April 4, 2024 09:53
@AdityaKhatri AdityaKhatri merged commit b0f857c into develop Apr 4, 2024
9 checks passed
@AdityaKhatri AdityaKhatri deleted the feature/lead-additional-filters branch April 4, 2024 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sudan45 sudan45 sudan45 approved these changes

@Rup-Narayan-Rajbanshi Rup-Narayan-Rajbanshi Rup-Narayan-Rajbanshi approved these changes

Assignees

@subinasr subinasr

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@thenav56 @Rup-Narayan-Rajbanshi @sudan45 @AdityaKhatri @subinasr