Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add project count in analysisframework schema #1404

Merged
merged 2 commits into from
Jan 10, 2024
Merged

add project count in analysisframework schema #1404

merged 2 commits into from
Jan 10, 2024

Conversation

sudan45
Copy link
Contributor

@sudan45 sudan45 commented Dec 29, 2023 •
edited
Loading

Changes

  • Add project count in analysisframework schema
  • include test project

This PR doesn't introduce any:

  • temporary files, auto-generated files or secret keys
  • n+1 queries
  • flake8 issues
  • print
  • typos
  • unwanted comments

This PR contains valid:

  • tests
  • permission checks (tests here too)
  • translations

@sudan45 sudan45 requested a review from thenav56 December 29, 2023 08:00
@sudan45 sudan45 self-assigned this Dec 29, 2023
@sudan45 sudan45 force-pushed the feature/add-project-count-in-analysisframework branch from 3a9f4e5 to e6f67e7 Compare December 29, 2023 08:06
thenav56
thenav56 requested changes Dec 29, 2023
View reviewed changes
apps/analysis_framework/schema.py Outdated Show resolved Hide resolved
apps/analysis_framework/schema.py Outdated Show resolved Hide resolved
@sudan45 sudan45 force-pushed the feature/add-project-count-in-analysisframework branch from e6f67e7 to 28f483a Compare December 29, 2023 08:13
@sudan45 sudan45 requested a review from thenav56 December 29, 2023 08:42
thenav56
thenav56 requested changes Dec 29, 2023
View reviewed changes
apps/analysis_framework/schema.py Outdated Show resolved Hide resolved
apps/analysis_framework/schema.py Outdated Show resolved Hide resolved
schema.graphql Outdated Show resolved Hide resolved
@sudan45 sudan45 force-pushed the feature/add-project-count-in-analysisframework branch from 389fb76 to 3540700 Compare December 29, 2023 08:59
@subinasr subinasr mentioned this pull request Jan 8, 2024
Merged
9 tasks
@subinasr subinasr assigned subinasr and unassigned sudan45 Jan 8, 2024
@AdityaKhatri AdityaKhatri force-pushed the feature/add-project-count-in-analysisframework branch 2 times, most recently from 210714e to 5fb57f5 Compare January 10, 2024 11:04
@AdityaKhatri AdityaKhatri merged commit 49fd3ba into develop Jan 10, 2024
9 checks passed
@AdityaKhatri AdityaKhatri deleted the feature/add-project-count-in-analysisframework branch January 10, 2024 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@subinasr subinasr subinasr approved these changes

@thenav56 thenav56 thenav56 approved these changes

Assignees

@subinasr subinasr

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sudan45 @thenav56 @subinasr @AdityaKhatri