Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add serializer validation and save data in connector #1400

Merged
merged 4 commits into from
Jan 11, 2024
Merged

add serializer validation and save data in connector #1400

merged 4 commits into from
Jan 11, 2024

Conversation

sudan45
Copy link
Contributor

@sudan45 sudan45 commented Dec 27, 2023 •
edited
Loading

Changes

  • Detailed list or prose of changes
  • Breaking changes
  • Changes to configurations

Mention related users here if any.

This PR doesn't introduce any:

  • temporary files, auto-generated files or secret keys
  • n+1 queries
  • flake8 issues
  • print
  • typos
  • unwanted comments

This PR contains valid:

  • tests
  • permission checks (tests here too)
  • translations

@sudan45 sudan45 requested a review from thenav56 December 27, 2023 10:18
@sudan45 sudan45 self-assigned this Dec 27, 2023
@thenav56 thenav56 force-pushed the fix/serializer_validation branch 3 times, most recently from c44cb71 to 8fe6017 Compare December 27, 2023 10:47
@sudan45 sudan45 force-pushed the fix/serializer_validation branch 3 times, most recently from 2a92e23 to 3d2ad00 Compare December 27, 2023 11:09
@thenav56 thenav56 mentioned this pull request Dec 28, 2023
Closed
9 tasks
@thenav56 thenav56 force-pushed the fix/serializer_validation branch from 662fa68 to 3503bbe Compare December 29, 2023 06:02
@sudan45 sudan45 changed the title serializer validation and save data in connector add serializer validation and save data in connector Dec 29, 2023
@AdityaKhatri AdityaKhatri force-pushed the fix/serializer_validation branch from cf58cb6 to 99d3697 Compare January 11, 2024 03:56
@AdityaKhatri AdityaKhatri merged commit 15e8608 into develop Jan 11, 2024
9 checks passed
@AdityaKhatri AdityaKhatri deleted the fix/serializer_validation branch January 11, 2024 04:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rup-Narayan-Rajbanshi Rup-Narayan-Rajbanshi Rup-Narayan-Rajbanshi approved these changes

@thenav56 thenav56 thenav56 approved these changes

Assignees

@sudan45 sudan45

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sudan45 @thenav56 @Rup-Narayan-Rajbanshi @AdityaKhatri