Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/geolocation mockdata #45

Merged
merged 5 commits into from
Feb 5, 2024
Merged

Fix/geolocation mockdata #45

merged 5 commits into from
Feb 5, 2024

Conversation

ranjan-stha
Copy link
Contributor

@ranjan-stha ranjan-stha commented Feb 1, 2024 •
edited
Loading

Changes

  • Updated the mock data related to geolocations
  • Postprocess the geolocation response

Mention related users here if any.

This PR doesn't introduce any:

  • temporary files, auto-generated files or secret keys
  • n+1 queries
  • flake8 issues
  • print
  • typos
  • unwanted comments

This PR contains valid:

  • tests
  • permission checks (tests here too)
  • translations

Rup-Narayan-Rajbanshi
Rup-Narayan-Rajbanshi requested changes Feb 2, 2024
View reviewed changes
analysis_module/mockserver.py Outdated Show resolved Hide resolved
analysis_module/mockserver.py Outdated Show resolved Hide resolved
@sudan45 sudan45 merged commit 47c7eac into main Feb 5, 2024
4 checks passed
@ranjan-stha ranjan-stha deleted the fix/geolocation_mockdata branch February 5, 2024 04:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sudan45 sudan45 sudan45 approved these changes

@Rup-Narayan-Rajbanshi Rup-Narayan-Rajbanshi Rup-Narayan-Rajbanshi approved these changes

Assignees

@sudan45 sudan45

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ranjan-stha @Rup-Narayan-Rajbanshi @sudan45