Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manage loading state for home and list views #77

Merged
merged 1 commit into from
Mar 26, 2024
Merged

Conversation

jtkabenni
Copy link
Collaborator

For an example of how to fill this template out, see this Pull Request.

Description

Fixing loading state bug for home and list views.

  • returns loading div in home and list views when data has not been loaded
  • update useShoppingLists and useShoppingListData functions in firebase.js to return loading state
  • updated lists and addListItem tests to account for new prop structure

Related Issue

#70

Acceptance Criteria

Type of Changes

Bug fix.

Updates

Before

https://www.loom.com/share/d7a73a6da0f74615bc3e212bc5af09d6?sid=ec3d28c6-1d31-483c-9e45-6f8885fa8535

After

https://www.loom.com/share/52570b94b8bd4d10b06b9830c73fdc17?sid=f0804d01-db37-4c6f-9af2-6f3bd4e4892c

Testing Steps / QA Criteria

Copy link

Visit the preview URL for this PR (updated for commit e769629):

https://tcl-67-smart-shopping-list--pr77-bug-loading-state-xajf2gkf.web.app

(expires Tue, 02 Apr 2024 05:18:36 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 1dc6f6876568bd8a1c97781eec7984835c207f7c

@flbarfield
Copy link
Collaborator

flbarfield commented Mar 26, 2024

I noticed that if the user isn't signed in yet, the "loading list" status is on.

Perhaps it should have some alternative displays until that condition is met?
Or maybe just display the list section, but with no list items?

Other than that, works great!

@jtkabenni
Copy link
Collaborator Author

jtkabenni commented Mar 26, 2024

I noticed that if the user isn't signed in yet, the "loading list" status is on.

Perhaps it should have some alternative displays until that condition is met? Or maybe just display the list section, but with no list items?

Other than that, works great!

@flbarfield Yeah I actually did add that as another issue #63 to manage the UI for before a user logs in. I think we should probably hide all of the elements on that page other than a login form.

@jtkabenni jtkabenni merged commit 19ad6c4 into main Mar 26, 2024
3 checks passed
@flbarfield flbarfield deleted the bug/loading-state branch March 27, 2024 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants