Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

limit to known phases #248

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

greencoloured
Copy link

@greencoloured greencoloured commented Jan 15, 2019

I have found with pinto that unexpected packages were getting pulled.

For example, the following will pull in Dist::Zilla along with its dependency on Moose.

pinto pull -s test ETHER/Task-Weaken-1.06.tar.gz

The culprit appears to be a required packages getting added for the phase:

X_Dist_Zilla

This patch limits the packages pulled by pinto to a known phase: configure, runtime, build or test.

@greencoloured
Copy link
Author

I can't say for sure that this is the correct approach for Dist::Zilla, I'm working on the assumption here that anything that Dist::Zilla actually wants used should appear in one of the standard phases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant