Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: Update CI run triggers #39

Merged
merged 1 commit into from
Jun 24, 2024
Merged

ci: Update CI run triggers #39

merged 1 commit into from
Jun 24, 2024

Conversation

matthewfeickert
Copy link
Contributor

@matthewfeickert matthewfeickert commented Jun 24, 2024 •
edited
Loading

Resolves #37

  • Add pull request, schedule, and workflow dispatch triggers for CI.
  • Add concurrency limits.
  • Use pytest CLI API.
  • Remove environment settings that aren't used.
  • Drop Python 3.7 from tests as not supported on all platforms and now EOL.

@matthewfeickert
Copy link
Contributor Author

Addresses issue with CI not running on PRs from #34 (comment).

@matthewfeickert
Copy link
Contributor Author

@j-s-ashley sorry I started this before reading your comment on #34 (comment), but this is ready for review now. The tests might not pass, but that's okay as this is updating the infrastructure.

@matthewfeickert matthewfeickert changed the title ci: Update CI to run triggers ci: Update CI run triggers Jun 24, 2024
@matthewfeickert
ci: Update CI run triggers
7f852dc 
* Add pull request, schedule, and workflow dispatch triggers for CI.
* Add concurrency limits.
* Use pytest CLI API.
* Remove environment settings that aren't used.
* Drop Python 3.7 from tests as not supported on all platforms and now EOL.
@j-s-ashley j-s-ashley merged commit bd92496 into thaler-lab:master Jun 24, 2024
1 of 10 checks passed
@matthewfeickert matthewfeickert deleted the ci/add-pr-tests branch June 24, 2024 16:26
@matthewfeickert matthewfeickert mentioned this pull request Jun 26, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@j-s-ashley j-s-ashley j-s-ashley approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ci: Add manual and pull request triggers to workflow
2 participants
@matthewfeickert @j-s-ashley