Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run with flask #153

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Run with flask #153

wants to merge 3 commits into from

Conversation

dmydlo
Copy link

@dmydlo dmydlo commented Oct 30, 2019

Make the flask CLI available.

@dmydlo
Copy link
Author

dmydlo commented Oct 30, 2019

Remove SECRET_KEY from the zeton/__init__.py file.

@visse0001
Copy link
Collaborator

Remove SECRET_KEY from the zeton/__init__.py file.

SECRET_KEY is still there

@dmydlo
Copy link
Author

dmydlo commented Oct 31, 2019

Remove SECRET_KEY from the zeton/__init__.py file.

SECRET_KEY is still there

Exactly

@bizmarcin
Copy link
Collaborator

Wygląda dobrze, ale... jest kilka nierozwiązanych referencji (repo czysto po clonie)
image

@patryklomza patryklomza self-requested a review November 17, 2019 21:39
Copy link
Collaborator

@patryklomza patryklomza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Działa jak powinno. Usunięcie nieużytych importów itp. trzeba zrobić dla całego projektu jako osobny issue.

Copy link
Collaborator

@patryklomza patryklomza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nie jestem pewny, czy potrzebujemy tych zmian.
U mnie serwer startuje poprawnie z CLI, tak samo mogę uruchomić flask shell. Poddaję temat do dyskusji.
P.S. nie mam pojęcia, czemu flask run nie działało podczas hacktoberfest w STX, z czego wyniknął impuls do zmiany obecnej w tym PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants