This repository has been archived by the owner on Apr 22, 2024. It is now read-only.
Bump dependencies and configure a nonroot user #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
nacx
commented
Mar 7, 2024
•
nacx
commented
- Bump all dependencies to their latest versions.
- Configure the image to run as a non-root user.
- Enable a scan workflow that uses https://github.com/anchore/grype to scan the images, which is the OSS version of the tool used to scan the images in IronBank.
sergicastro
reviewed
Mar 7, 2024
.github/workflows/scan.yaml
Outdated
| steps: | ||
| - uses: docker/setup-qemu-action@v3 | ||
| with: | ||
| platforms: amd64,arm64 |
There was a problem hiding this comment.
why do you need to arm64 if DOCKER_TARGETS is set to amd64 ?
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #82 +/- ##
=======================================
Coverage 92.61% 92.61%
=======================================
Files 23 23
Lines 1530 1530
=======================================
Hits 1417 1417
Misses 69 69
Partials 44 44 |
sergicastro
approved these changes
Mar 7, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.