Skip to content
This repository has been archived by the owner on Apr 22, 2024. It is now read-only.

Remove unused cancellable context #59

Merged
merged 1 commit into from
Feb 26, 2024
Merged

Remove unused cancellable context #59

merged 1 commit into from
Feb 26, 2024

Conversation

nacx
Copy link
Member

@nacx nacx commented Feb 26, 2024

This was probably a leftover from previous iterations?

@nacx nacx requested a review from sergicastro February 26, 2024 11:00
Copy link

codecov bot commented Feb 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.42%. Comparing base (f27468b) to head (da739e5).

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #59      +/-   ##
==========================================
- Coverage   93.44%   93.42%   -0.02%     
==========================================
  Files          22       22              
  Lines        1433     1430       -3     
==========================================
- Hits         1339     1336       -3     
  Misses         56       56              
  Partials       38       38              
Files Coverage Δ
internal/tls.go 89.02% <ø> (-0.39%) ⬇️

Copy link
Contributor

@sergicastro sergicastro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, totally! thanks

@sergicastro sergicastro merged commit bef473d into main Feb 26, 2024
11 checks passed
@sergicastro sergicastro deleted the unused-ctx branch February 26, 2024 11:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants