This repository has been archived by the owner on Apr 22, 2024. It is now read-only.
Allow golang duration format in trusted CA refresh interval #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nacx
reviewed
Feb 26, 2024
| // Optional. | ||
| google.protobuf.Duration trusted_certificate_authority_refresh_interval = 22; | ||
| string trusted_certificate_authority_refresh_interval = 22; |
There was a problem hiding this comment.
Would this work with the decimal format? If not, I think it's OK to leave the field as-is, to preserve backward compatibility (even if no one is going to ever configure something at nanosecond precision)
There was a problem hiding this comment.
This is a new field I introduced in the PR #50.
The old authservice has no way to read CA from files and so to configure a refresh interval.
There was a problem hiding this comment.
And no, the decimal format would not work.
sergicastro
force-pushed
the
golang-duration
branch
from
b4cbfec to
4e360d6
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #53 +/- ##
==========================================
+ Coverage 93.44% 93.45% +0.01%
==========================================
Files 22 22
Lines 1433 1437 +4
==========================================
+ Hits 1339 1343 +4
Misses 56 56
Partials 38 38
|
|
Closing in favour of #57 So, only support seconds with no mention about nanos. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This would allow to use the golang
time.Durationstyle to setup the trusted CA refresh interval.Depends on #52 to pass the checks.