Skip to content
This repository has been archived by the owner on Apr 22, 2024. It is now read-only.

Properly validate configuration #2

Merged
merged 4 commits into from
Feb 12, 2024
Merged

Properly validate configuration #2

merged 4 commits into from
Feb 12, 2024

Conversation

nacx
Copy link
Member

@nacx nacx commented Feb 9, 2024

No description provided.

@nacx nacx requested a review from sergicastro February 9, 2024 17:16
Copy link

codecov bot commented Feb 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6844fc0) 54.54% compared to head (5236766) 84.61%.

Additional details and impacted files
@@             Coverage Diff             @@
##             main       #2       +/-   ##
===========================================
+ Coverage   54.54%   84.61%   +30.06%     
===========================================
  Files           5        5               
  Lines         242      247        +5     
===========================================
+ Hits          132      209       +77     
+ Misses        103       34       -69     
+ Partials        7        4        -3     
Files Coverage Δ
internal/config.go 100.00% <100.00%> (+35.71%) ⬆️
internal/server/server.go 88.88% <ø> (+8.33%) ⬆️

... and 2 files with indirect coverage changes

@sergicastro sergicastro merged commit d9be6fe into main Feb 12, 2024
8 checks passed
@sergicastro sergicastro deleted the cfg branch February 12, 2024 08:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants