Skip to content
This repository has been archived by the owner on Apr 22, 2024. It is now read-only.

Load the session stores for all OIDC configurations #10

Merged
merged 2 commits into from
Feb 14, 2024
Merged

Load the session stores for all OIDC configurations #10

merged 2 commits into from
Feb 14, 2024

Conversation

nacx
Copy link
Member

@nacx nacx commented Feb 13, 2024

Depends on #9
Opening as a draft until the PR this depends on is merged.

@nacx nacx requested a review from sergicastro February 13, 2024 16:46
Base automatically changed from config to main February 13, 2024 16:47
@nacx nacx marked this pull request as ready for review February 13, 2024 16:48
Copy link

codecov bot commented Feb 13, 2024

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (58dfe7b) 91.23% compared to head (9a2a212) 93.88%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #10      +/-   ##
==========================================
+ Coverage   91.23%   93.88%   +2.64%     
==========================================
  Files          10       11       +1     
  Lines         502      523      +21     
==========================================
+ Hits          458      491      +33     
+ Misses         39       28      -11     
+ Partials        5        4       -1     
Files Coverage Δ
internal/oidc/session.go 100.00% <100.00%> (ø)
internal/server/authz.go 91.72% <83.33%> (+0.06%) ⬆️
internal/authz/oidc.go 0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes

@nacx nacx enabled auto-merge (squash) February 13, 2024 17:08
Copy link
Contributor

@sergicastro sergicastro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that looks nice!

@nacx nacx merged commit 9d0e3d3 into main Feb 14, 2024
7 of 8 checks passed
@nacx nacx deleted the store branch February 14, 2024 09:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants