Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge duplicate "version command" tests and remove extemporaneous one #1141

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

swainn
Copy link
Member

@swainn swainn commented Jan 6, 2025

Description

I discovered that there were two test_version_command tests testing basically the same thing. This PR merges the functionality and removes the extra one. Having duplicate tests for this is actually detrimental to the contributor tutorial I'm writing, which modifies the version command.

Changes Made to Code:

  • Removed unit_tests/test_version_command.py
  • Updated unit_tests/test_tethys_cli/test_vesrion_command.py with mocking approach of the other and tweaked a little.
  • Adds tests from some recent additions to site_settings.py that had missing lines of coverage.
  • Fixed an issue with the log message in the new site_settings.py code that was untested.
  • Fixed typos and revise the Pull Request template

Quality Checks

  • New code is 100% tested
  • Code has been formatted
  • Code has been linted
  • Docstrings for new methods have been added

@swainn swainn self-assigned this Jan 6, 2025
@coveralls
Copy link

coveralls commented Jan 7, 2025

Coverage Status

coverage: 100.0% (+0.03%) from 99.973%
when pulling f241f17 on remove-redundant-version-command-test
into e95effb on main.

@swainn swainn requested review from sdc50 and shawncrawley January 8, 2025 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants