Allow anonymous users to get condor job status #1119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
November 27, 2024 16:19
- Updated existing tests to ensure they handle scenarios involving anonymous users correctly. - Added new tests to cover additional cases where an anonymous user is involved.
swainn
approved these changes
Dec 13, 2024
sdc50
approved these changes
Dec 20, 2024
swainn
pushed a commit
that referenced
this pull request
Dec 20, 2024
* Allow anonymous users to get condor job status * Add type checks in anonymous user checks * Update and add tests for when an anonymous user is used - Updated existing tests to ensure they handle scenarios involving anonymous users correctly. - Added new tests to cover additional cases where an anonymous user is involved. * Add unit test for JobManager.create_job that uses an anonymous user * Format test_job_manager.py using python black formatter --------- Co-authored-by: James Dolinar <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This merge request addresses anonymous users being unable to get the status of a condor job. Without this fix, the anonymous user cannot view a jobs_table gizmo that correctly refreshes the status of its jobs.
Changes Made to Code:
Related
Additional Notes
Quality Checks