-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated schema to enforce skill levels. #7
Open
Schoonology
wants to merge
5
commits into
main
Choose a base branch
from
update-schema
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,19 @@ | ||
{ | ||
"$schema": "http://json-schema.org/draft-04/schema#", | ||
"title": "Resume Schema Extension for Test Double", | ||
"type": "object", | ||
"properties": { | ||
"skills": { | ||
"type": "array", | ||
"items": { | ||
"type": "object", | ||
"properties": { | ||
"level": { | ||
"type": "string", | ||
"enum": ["Teaching others", "Pairing on", "Excited about"] | ||
} | ||
} | ||
} | ||
} | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,24 @@ | ||
var Ajv = require('ajv') | ||
|
||
// See https://github.com/epoberezkin/ajv#using-version-6 for an explanation | ||
// of these settings, which are required because JSONResume uses draft-04. | ||
var ajv = new Ajv({ | ||
allErrors: true, | ||
schemaId: 'id' | ||
}) | ||
ajv.addMetaSchema(require('ajv/lib/refs/json-schema-draft-04.json')) | ||
|
||
function validateAgainstSchema(schema, data) { | ||
return Promise.resolve(ajv.validate(schema, data)) | ||
.then(function (valid) { | ||
if (!valid) { | ||
var error = new Error('Validation failed') | ||
error.errors = ajv.errors | ||
throw error | ||
} | ||
|
||
return data | ||
}) | ||
} | ||
|
||
module.exports = validateAgainstSchema |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -13,14 +13,15 @@ | |
"author": "Michael Schoonmaker <[email protected]> (https://www.schoonology.com/)", | ||
"license": "MIT", | ||
"dependencies": { | ||
"cson": "^4.0.0", | ||
"debug": "~2.3.3", | ||
"ajv": "~6.2.1", | ||
"cson-parser": "~3.0.0", | ||
"debug": "~3.1.0", | ||
"hummus": "~1.0.65", | ||
"jstransformer-sass": "~0.1.0", | ||
"jstransformer-sass": "~1.0.0", | ||
"marked": "~0.3.6", | ||
"minimist": "~1.2.0", | ||
"moment": "~2.17.0", | ||
"nightmare": "~2.8.1", | ||
"moment": "~2.21.0", | ||
"nightmare": "~3.0.0", | ||
"pug": "~2.0.0-beta6", | ||
"resume-schema": "0.0.16", | ||
"temp": "~0.8.3", | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Learned something about JSON schemas, very cool that they can be extended this way.
I like the intention behind this, making clear that we don't find much value in using "level" to rank our skills/languages etc. These specific categories don't resonate with me though, so I am glad for now that validation doesn't stop the build ;-) More specifically, they actually apply very well to all the skills I want to list on my resume, I am excited about and love to pair and teach (and learn) all of them!
I have some ideas I would like to mess with, but I'll express them in the form of a PR once I get some time to work on it.