Initialize signer lazily #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By initializing the signer lazily, only when used the first time, we also postpone the check for missing `secret_key` and `principal_id`. This makes it possible to load the Rails environment without setting the Azure Storage credentials in environments that do not need to connect to Azure. For example, a build step that precompiles assets needs to load the environments, but usually does not need Azure Storage. Before this change, one would still have to set some (possibly fake) `secret_key` or `principal_id` in such build step, while with this change those can be omitted in any situation in which no real calls to the Azure API will be made.
|
The last two weeks were pretty buzy, I'll review soon. I didn't consider asset precompilation. I think a lazy option would make sense. |
JoeDupuis
force-pushed
the
lazy-signer-instantiation
branch
from
8e4ff6e to
4d5b925
Compare
JoeDupuis
approved these changes
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By initializing the signer lazily, only when used the first time, the check for missing
secret_keyandprincipal_idis also postponed until an actual API call to Azure is made.This makes it possible to load the Rails environment without setting the Azure Storage credentials in environments that do not need to connect to Azure. For example, a build step that precompiles assets needs to load the environments, but usually does not need Azure Storage. Before this change, one would still have to set some (possibly fake)
secret_keyorprincipal_idin such build step, while with this change those can be omitted in any environment in which no real calls to the Azure API will be made.