-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change the Docker Image used by the Presto module to prestodb/presto
#8946
base: main
Are you sure you want to change the base?
Conversation
Thanks for your contribution, @linghengqian! In order to fix the build, please run |
this.waitStrategy =
new LogMessageWaitStrategy()
.withRegEx(".*======== SERVER STARTED ========.*")
.withStartupTimeout(Duration.of(60, ChronoUnit.SECONDS)); |
thanks for the update, @linghengqian ! I see everything green but failing locally. So, hopefully the other issue in presto repository is solved soon and the module can provide a reliable wait strategy. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Since Missing an HTTP endpoint to ensure the Presto Docker Container is ready prestodb/presto#23226 and SQLException thrown when Connection.setAutoCommit(false) and then Connection.setAutoCommit(false); prestodb/presto#15916 have been resolved, it seems that there is nothing that can prevent the current PR from continuing to merge.
f1aba97
to
1a1a1f0
Compare
503ea1b
to
b1bad28
Compare
ghcr.io/trinodb/presto
and needs to be updated toprestodb/presto
#8657 .prestodb/presto
.