-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Mochawesome skipped and pending tests no longer generate a failed result #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s for the mocha parser
…ped tests for the mocha parser" This reverts commit eaa50d7.
hey @jmuleiro ,
|
@ASaiAnudeep @leelaprasadv done! |
@jmuleiro do you mind updating the node versions to latest in build yaml file.
|
@ASaiAnudeep done, also took the liberty of fixing a small |
ASaiAnudeep
approved these changes
May 10, 2024
jmuleiro
changed the title
Feature: Mochawesome parser
Feature: Mochawesome skipped and pending tests no longer generate a failed result
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
I recently started using this tool to integrate
mochawesome
reports with Slack. It turns out, in my test cases I have feature flags that cause Cypress tests to be skipped. Mochawesome has two types of skipped tests:skipped
andpending
. But as it turns out,mocha
does not. This caused the parser to interpret tests marked asskipped
by Mochawesome as failures, and to list them as such.I updated the
mocha
parser so that it deals with this issue if it findsskipped
keys in test results/suites.Changes
mocha
parserskipped
property, it adds those tests to the list of tests marked with a pending statemochawesome
test case for results with skipped, non-pending testsskipped-tests
topending-tests
to match its behavior (and updated test description)node-version
to latestReferenceError
when result type is set to unsupported parserSample file
Here's a sample JSON test result with which you can reproduce the unintended behavior:
flipcard-submit.json