Make deployment name an optional parameter. (#104)

* Updated code to make deployment name parameter optional * Added test for optional deployment name parameter Signed-off-by: Rupesh0688 <[email protected]> Co-authored-by: Vikram Karve <[email protected]>
test-kitchen · Jun 27, 2023 · feb9c25 · feb9c25
1 parent f7b56d8
commit feb9c25
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 1 deletion.
diff --git a/lib/vra/deployment_request.rb b/lib/vra/deployment_request.rb
@@ -85,7 +85,7 @@ def hash_parameters
 
     def validate!
       missing_params = []
-      %i{image_mapping flavor_mapping name project_id}.each do |arg|
+      %i{image_mapping flavor_mapping project_id}.each do |arg|
         missing_params << arg if send(arg).nil?
       end
 

diff --git a/spec/deployment_request_spec.rb b/spec/deployment_request_spec.rb
@@ -71,6 +71,17 @@
       expect { request.send(:validate!) }.not_to raise_error(ArgumentError)
     end
 
+    it "should not return error if deployment name is missing" do
+      request = described_class.new(client, catalog_id)
+
+      request.image_mapping  = "Centos Image"
+      request.flavor_mapping = "Small"
+      request.version        = "1"
+      request.project_id     = "pro-123"
+
+      expect { request.send(:validate!) }.not_to raise_error(ArgumentError)
+    end
+
     context "versions" do
       let(:dep_request) do
         described_class.new(