-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds colcon ignore in order to ignore ROS1 packages from colcon build in ROS2 #218
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doesn't Colcon also build ROS1 packages?
@Levi-Armstrong it errors out whenever it finds any catkin related commands in the CMakeLists.txt. This change would allow to build the pure cmake packages in a colcon ROS2 workspace. |
I believe the reason it errors out using colcon is because the package.xml has not been updated to format 2 and it needs the <build_type>catkin</build_type> added. |
It would still fail in a ROS2 workspace because the ROS1 libraries aren't part of that environment |
Furthermore, in a colcon ROS2 ws that also uses tesseract_ros2 there will be conflicting packages because they're named the same as those in tesseract/tesseract_ros |
Lets discuss further on issue #207. |
@Levi-Armstrong Until #207 is implemented, can we just COLCON_IGNORE tesseract_ros and tesseract_python? Having these in here is making CI problematic. |
@Levi-Armstrong ping |
@jrgnicho Can you rebase? I think it should fix CI to get this merged. |
I think we'll have to ignore tesseract_python as well since it uses tesseract_rosutils |
@Levi-Armstrong I just rebased |
@jrgnicho Something is still not happy. |
I don't think this is going to work. I thought that catkin only obeyed CATKIN_IGNORE, but colcon ignored all. That does not appear to be the case. See HERE linked from THIS issue which I see Jorge is a part of. Perhaps we should just add a check to the package.xml/cmake like we do in yak_ros? It looks like it doesn't like that we are trying to run tests on tesseract_ros_examples using PKGS_DOWNSTREAM. |
This has been replaced by #241 |
No description provided.