-
-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build for release, auto-updater, website #65
Conversation
This reverts commit 425f9d1.
WSC.js
Outdated
}) | ||
}) | ||
const fs = require('fs') | ||
const path = require('path') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the path and fs libraries are defined on global (see index.js)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch, thanks!
@terreng I dont know if you saw or not, but the htaccess config page (https://simplewebserver.org/docs/swsaccess.html#how-to) is a mess. Could you fix this and possibly redo a lot of the documentation, I really am not good at explaining things in words and sounds like a jumble of info half the time, sorry. |
Sure thing, I would be happy to make it neater. If you want to though, it might be good practice to try rewriting some of it yourself. Being able to write good documentation is an important skill to have when writing code. I haven't had an opportunity to explore .swshtaccess files, custom scripts, or custom request handlers in very much detail yet. I might have new ideas or suggestions for changes for those features. |
Yeah. If you wouldnt mind could you help me learn how to right those? Like you right some and I use that as an example to write the others and you tell me how I did?
If you do let me know. I do really enjoy working on the whole htaccess thing |
Hey @terreng quick question. I actually have to write a bunch of documentation for one of my other projects and I’ve been thinking about how to do the UI. I was wondering, did you use a template? If so could you point me to what you used. Thanks! |
Do you mean the website, or the app UI? I used VuePress for the website (to turn all the .md files into a website). However, I would recommend using something simpler like GitHub pages. It's built-in to GitHub, has several theme options, and gives you a URL. |
The website, sorry should have specified that
Is this what’s in the website folder?
We actually already have a website, I just haven’t started on the documentation part (and the UI of the website is a mess except for this one page) Thanks! |
Yes There are quite a few projects similar to it, such as readthedocs.org. |
Awesome! Thank you |
editing config, https, logs)