Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build for release, auto-updater, website #65

Merged
merged 88 commits into from
May 17, 2022
Merged

Build for release, auto-updater, website #65

merged 88 commits into from
May 17, 2022

Conversation

terreng
Copy link
Owner

@terreng terreng commented Feb 5, 2022

  • Closes Auto-updater #5
  • IP change UI logic once Fix error messages #57 merged
  • Add compression option
  • Build (Closes Releases #24 ) - include Linux?
  • Install instructions for website (Also build from source instructions)
  • remove auto updater option for microsoft store version
  • appx build
  • Add missing guides for website (editing config, https, logs)
  • finish coming from wsc page
  • add ipv6 option to docs
  • add option to disable logging
  • figure out why logging doesn't work on macos
  • Update documentation files and README
  • Closes Website #4
  • Fix settings title cutoff on the g
  • Update documentation link in the app to go to exact page

@terreng terreng self-assigned this Feb 5, 2022
@terreng terreng marked this pull request as draft February 5, 2022 17:05
@terreng terreng changed the title Build for release, auto-updater, website / documentation Build for release, auto-updater, website Feb 15, 2022
WSC.js Outdated
})
})
const fs = require('fs')
const path = require('path')
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the path and fs libraries are defined on global (see index.js)

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks!

@terreng terreng marked this pull request as ready for review May 17, 2022 02:59
@terreng terreng merged commit 26135e0 into main May 17, 2022
@terreng terreng deleted the new-ui branch May 17, 2022 03:00
@ethanaobrien
Copy link
Collaborator

@terreng I dont know if you saw or not, but the htaccess config page (https://simplewebserver.org/docs/swsaccess.html#how-to) is a mess. Could you fix this and possibly redo a lot of the documentation, I really am not good at explaining things in words and sounds like a jumble of info half the time, sorry.

@terreng
Copy link
Owner Author

terreng commented May 24, 2022

@terreng I dont know if you saw or not, but the htaccess config page (https://simplewebserver.org/docs/swsaccess.html#how-to) is a mess. Could you fix this and possibly redo a lot of the documentation, I really am not good at explaining things in words and sounds like a jumble of info half the time, sorry.

Sure thing, I would be happy to make it neater. If you want to though, it might be good practice to try rewriting some of it yourself. Being able to write good documentation is an important skill to have when writing code.

I haven't had an opportunity to explore .swshtaccess files, custom scripts, or custom request handlers in very much detail yet. I might have new ideas or suggestions for changes for those features.

@ethanaobrien
Copy link
Collaborator

If you wan to though, it might be good practice to try rewriting some of it yourself.

Yeah. If you wouldnt mind could you help me learn how to right those? Like you right some and I use that as an example to write the others and you tell me how I did?

I might have new ideas or suggestions for changes for those features.

If you do let me know. I do really enjoy working on the whole htaccess thing

@ethanaobrien
Copy link
Collaborator

Hey @terreng quick question.

I actually have to write a bunch of documentation for one of my other projects and I’ve been thinking about how to do the UI. I was wondering, did you use a template? If so could you point me to what you used.

Thanks!

@terreng
Copy link
Owner Author

terreng commented May 28, 2022

I actually have to write a bunch of documentation for one of my other projects and I’ve been thinking about how to do the UI. I was wondering, did you use a template? If so could you point me to what you used.

Do you mean the website, or the app UI? I used VuePress for the website (to turn all the .md files into a website). However, I would recommend using something simpler like GitHub pages. It's built-in to GitHub, has several theme options, and gives you a URL.

@ethanaobrien
Copy link
Collaborator

@terreng

Do you mean the website, or the app UI?

The website, sorry should have specified that

I used VuePress for the website (to turn all the .md files into a website).

Is this what’s in the website folder?

However, I would recommend using something simpler like GitHub pages. It's built-in to GitHub, has several theme options, and gives you a URL.

We actually already have a website, I just haven’t started on the documentation part (and the UI of the website is a mess except for this one page)

Thanks!

@terreng
Copy link
Owner Author

terreng commented May 28, 2022

Is this what’s in the website folder?

Yes

There are quite a few projects similar to it, such as readthedocs.org.

@ethanaobrien
Copy link
Collaborator

Awesome! Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Releases Auto-updater Website
2 participants