-
Notifications
You must be signed in to change notification settings - Fork 206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tests for external projects #327
base: master
Are you sure you want to change the base?
Add tests for external projects #327
Conversation
22bc444
to
fc430dd
Compare
I am currently working on updating quicksand for the current version of Terra. When I have it running, should that become part of this test package, and what should I do with regards to that? |
Yes, if you have significant pieces of Terra code (ideally with tests), let's include them as external tests on the CI. The goal of this effort is to have as broad test coverage as possible, so that we can have some degree of assurance that we aren't breaking the ecosystem when we make changes. Depending on whether you get to it before or after this PR merges, we could either add it here or as a new PR. |
I don't anticipate getting it here before this PR merges. Quicksand has a considerable amount of nontrivial code in it, and large parts need major rewrites to fit the changes to the language since it was last maintained. |
@elliottslaughter I think Opt is GPU only. |
@elliottslaughter Yes, unfortunately Opt is currently without non-CUDA support. CI would be invaluable, and this limitation has come up before; so I'm seriously considering writing a small CUDA-emulation shim for the CPU (not built initially for performance) to have in Opt. |
4e9d211
to
d1792ae
Compare
Current status:
Deferred:
Others?