Allow consuming TF code to alter wait_for_capacity_timeout. #23
Conversation
Use name_prefix so we can create_before_destroy.
| value = "${var.name} ${var.tagName}" | ||
| propagate_at_launch = true | ||
| }] | ||
| name_prefix = "asg-${aws_launch_configuration.ecs.name}-" |
There was a problem hiding this comment.
I think this change will mean we'll need to cut a new major version release. Am I reading that right? Meaning, if someone upgrades to this version of the module, it'll tear down and recreate the autoscaling groups on them? (I haven't had a chance to pull this code and test)
There was a problem hiding this comment.
You are correct that it'll tear down any existing ASGs and bring them backup with prefixed names.
| propagate_at_launch = true | ||
| }, | ||
| { | ||
| key = "Terraform" |
| min_size = "${var.min_servers}" | ||
| max_size = "${var.max_servers}" | ||
| desired_capacity = "${var.servers}" | ||
| wait_for_capacity_timeout = "${var.wait_for_capacity_timeout}" |
There was a problem hiding this comment.
Does this add a similar function to heartbeat_timeout ?
There was a problem hiding this comment.
Not really. It's how long TF will wait for a capacity change before timing out. I added it because we had an ASG I wanted to take from 10 to 1 and it timed out.
| @@ -100,7 +113,8 @@ resource "aws_security_group" "ecs" { | |||
| } | |||
|
|
|||
| tags { | |||
| Name = "ecs-sg-${var.name}" | |||
| Name = "ecs-sg-${var.name}" | |||
| Terraform = "yes" | |||
There was a problem hiding this comment.
I like these tags, one though, what would you think about the tags reading "true" rather then "yes" ?
There was a problem hiding this comment.
I have zero preference. We use this pattern internally, but happy to follow whatever patterns the community/maintainers prefer.
There was a problem hiding this comment.
cool, lets switch this to true and I'll merge PR in.
|
It looks like the last PR added a conflict, so this branch may need a rebase. |
Includes a default value of
10m, which is TF's default as well. We have some ASGs that keep timing out when we adjust capacity.