Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Allow adding iss for the oidc assumable role #541

Conversation

whatisusername
Copy link

Description

Add the iss condition to the assumable OIDC role.

Motivation and Context

The current implementation of the assumable OIDC role does not include the iss condition in the trust policy. This update follows the pattern introduced in OIDC role PR #507 to ensure consistency and compatibility with common OIDC providers.

Breaking Changes

None. This change is backward-compatible as it only adds an additional condition without altering existing functionality.

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request

pre-commit-result

@bryantbiggs
Copy link
Member

this is not correct - however, you can use provider_trust_policy_conditions to provide generic assume role conditions already so closing this out

@whatisusername whatisusername deleted the feature/add-iss-to-oidc-assumable-role branch December 27, 2024 01:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants