Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add role_requires_session_name #491

Conversation

sebastianvoss
Copy link

Description

Enforce users to set the role-session-name to their user name when assuming a role. See https://aws.amazon.com/blogs/security/easily-control-naming-individual-iam-role-sessions/ for details.

Motivation and Context

This allows to identify user activities in AWS audit logs (e.g. EKS audit logs) based on a reliable identifier. If the user can set role-session-name to an arbitrary value this would not be possible.

Breaking Changes

Nothing.

How Has This Been Tested?

I tested this using my fork in our AWS account.

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request

@sebastianvoss sebastianvoss changed the title Add role_requires_session_name feat: add role_requires_session_name May 25, 2024
@sebastianvoss sebastianvoss changed the title feat: add role_requires_session_name feat: Add role_requires_session_name May 25, 2024
Copy link

This PR has been automatically marked as stale because it has been open 30 days
with no activity. Remove stale label or comment or this PR will be closed in 10 days

@github-actions github-actions bot added the stale label Jun 25, 2024
@sebastianvoss
Copy link
Author

Is there anything missing? Please just let me know.

@github-actions github-actions bot removed the stale label Jul 5, 2024
Copy link

github-actions bot commented Aug 4, 2024

This PR has been automatically marked as stale because it has been open 30 days
with no activity. Remove stale label or comment or this PR will be closed in 10 days

@github-actions github-actions bot added the stale label Aug 4, 2024
@sebastianvoss
Copy link
Author

still relevant

@github-actions github-actions bot removed the stale label Aug 5, 2024
Copy link

This PR has been automatically marked as stale because it has been open 30 days
with no activity. Remove stale label or comment or this PR will be closed in 10 days

@github-actions github-actions bot added the stale label Sep 16, 2024
Copy link

This PR was automatically closed because of stale in 10 days

@github-actions github-actions bot closed this Sep 27, 2024
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant