Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add default description for role #453

Conversation

AndrewCharlesHay
Copy link
Contributor

@AndrewCharlesHay AndrewCharlesHay commented Jan 16, 2024

Description

Creates a default role description for the oidc provider

Motivation and Context

Creates more clarity and traceability for IAM roles by default

Breaking Changes

None

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request

@bryantbiggs
Copy link
Member

thank you but this is not valid - we can't have a default description that is only applicable to one of the scenarios supported by this sub-module

@AndrewCharlesHay
Copy link
Contributor Author

AndrewCharlesHay commented Jan 16, 2024

thank you but this is not valid - we can't have a default description that is only applicable to one of the scenarios supported by this sub-module

oh whoops you're right. I didn't think about the fact that it's used for other scenarios. Would it be ok if it checked attach_external_dns_policy and other similar variables or no?

@AndrewCharlesHay AndrewCharlesHay deleted the feature/default-role-description branch January 16, 2024 21:13
@bryantbiggs
Copy link
Member

what problem are you trying to solve?

@AndrewCharlesHay
Copy link
Contributor Author

what problem are you trying to solve?

Just provide a good default role description. I'm fine if you'd prefer not to have the check

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants