-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Remove the invalid provider
argument from the oidc_providers
variable description
#452
docs: Remove the invalid provider
argument from the oidc_providers
variable description
#452
Conversation
I didn't mean to commit the SID addition to this PR. I can make a new PR if you want. |
provider
argument from the oidc_providers
variable description
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you
@bryantbiggs Thank you for the merge! I understand if you want them in a separate PR. But what is wrong with changing the type to |
when you go with a type, other than foo = {
one = {
hot = true
cups = 2
colors = ["orange", "blue"]
}
two = {
hot = false
cups = 1
}
} So we typically just default to |
Ohh yeah I've run into that before. But we would want to ensure that every object has just |
Both attributes are referenced in each iteration so we need both and wouldn't want anything else right? I guess it would somewhat unnecessarily make things not backwards compatible. |
This PR is included in version 5.33.1 🎉 |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Description
The
provider
attribute is never accessed and thus shouldn't be listed. It also changes the type ofoidc_providers
fromany
to amap(any)
because it is a map.Motivation and Context
It clutters the requirements for the variable and thus should be removed
Breaking Changes
If someone used to pass something into
oidc_providers
it will now throw an error at an earlier stage of validationHow Has This Been Tested?
examples/*
to demonstrate and validate my change(s)examples/*
projectspre-commit run -a
on my pull request