Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Ignore change name at aws_appautoscaling_policy #80

Closed

Conversation

sebastianarca
Copy link

Description

Add lifecycle ignore_changes to aws_appautoscaling_policy.table_read_policy and aws_appautoscaling_policy.table_write_policy

Motivation and Context

#79

Breaking Changes

No, no problem

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request

@bryantbiggs
Copy link
Member

Why would we ignore this?

@sebastianarca
Copy link
Author

sebastianarca commented Nov 15, 2023

Because when the resource is created from the web console the name is different and when importing the state it will always try to destroy the resource. For resources that are productive it is a problem.
In the issue I add more details and examples.

If I am wrong, please enlighten me on how best to approach a solution to the problem.

@bryantbiggs
Copy link
Member

I think the issue is that you are not using Terraform to create the resources. Yes, Terraform can import resources but we don't design modules from an import first perspective - we design modules from the perspective that users will use the module to create the resources. I would suggest avoid creating resources outside of Terraform - closing this since its not something we would want to support

@sebastianarca
Copy link
Author

It is a shame that it is the main focus because it is exactly the need I have. Anyway, I understand perfectly the explanation.
Thank you very much for taking the time to review this case.

@hankwallace
Copy link

@bryantbiggs It's unfortunate that you closed this since many organizations have infrastructure in place before adopting terraform.

@bryantbiggs
Copy link
Member

@hankwallace and how do you suggest we accommodate all of those various ways that others have created infrastructure within this project?

Copy link

github-actions bot commented Jan 4, 2024

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants