Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add depends_on for aws_autoscaling_policy #279

Closed
wants to merge 1 commit into from

Conversation

TomasKohout
Copy link

@TomasKohout TomasKohout commented Oct 10, 2024

Description

Right now, it's not possible to create aws_autoscaling_policy because it will fail on validation (no target group attached).

Error: creating Auto Scaling Policy (request-count-per-target): operation error Auto Scaling: PutScalingPolicy, https response error StatusCode: 400, RequestID: xxxxxx, api error ValidationError: Target group not attached to the Auto Scaling group

Motivation and Context

Will attachment before creating the scaling policy.

Breaking Changes

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request

@TomasKohout TomasKohout changed the title fix: add depends_on for aws_autoscaling_policy Fix: add depends_on for aws_autoscaling_policy Oct 10, 2024
@TomasKohout TomasKohout changed the title Fix: add depends_on for aws_autoscaling_policy fix: Add depends_on for aws_autoscaling_policy Oct 10, 2024
@TomasKohout
Copy link
Author

Hi, @bryantbiggs , please have a look. Thanks! 🙂

Copy link
Member

@bryantbiggs bryantbiggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should start with an issue and a reproduction

Copy link

This PR has been automatically marked as stale because it has been open 30 days
with no activity. Remove stale label or comment or this PR will be closed in 10 days

@github-actions github-actions bot added the stale label Nov 17, 2024
Copy link

This PR was automatically closed because of stale in 10 days

@github-actions github-actions bot closed this Nov 28, 2024
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants