Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add note for next breaking change to remove load_balancers and target_group_arns from use #253

Merged
merged 2 commits into from
Nov 30, 2023
Merged

docs: Add note for next breaking change to remove load_balancers and target_group_arns from use #253

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6b62ba2
docs: Add note for next breaking change to remove `load_balancers` an…
bryantbiggs Nov 30, 2023
5223764
fix: Formatting
bryantbiggs Nov 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -372,7 +372,9 @@ resource "aws_autoscaling_group" "this" {
default_instance_warmup = var.default_instance_warmup
protect_from_scale_in = var.protect_from_scale_in

load_balancers = var.load_balancers
# TODO - remove at next breaking change. Use `traffic_source_identifier`/`traffic_source_type` instead
load_balancers = var.load_balancers
# TODO - remove at next breaking change. Use `traffic_source_identifier`/`traffic_source_type` instead
target_group_arns = var.target_group_arns
placement_group = var.placement_group
health_check_type = var.health_check_type
Expand Down