added configuration for the delay and mintimeout for slow hardware #139
+76
−26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@VoyTechnology Looks like this PR could be quite useful. |
|
@VoyTechnology would be great to put this feature in |
VoyTechnology
requested changes
Jan 16, 2024
|
Sure, I will address the suggestions in the next few days |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added an option to control the configuration of the provider:
provider virtualbox {
delay = 60 // default hardcoded value was 30
mintimeout = 5 // default hardcoded value was 1
}
This will allow waiting for the VMs to become ready even on slow hardware and will give control over this to the end-user.