Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

uv: patch venv libc detection #21942

Merged
merged 1 commit into from
Oct 23, 2024
Merged

uv: patch venv libc detection #21942

merged 1 commit into from
Oct 23, 2024

Conversation

Mause
Copy link
Contributor

@Mause Mause commented Oct 23, 2024

This allows uv to detect the termux installed python version, which doesn't use musl or glibc

licy183
licy183 approved these changes Oct 23, 2024
View reviewed changes
Copy link
Member

@licy183 licy183 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

twaik
twaik approved these changes Oct 23, 2024
View reviewed changes
Copy link
Member

@twaik twaik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will be merged in 24 hours if no one minds or when it gets one more approve.

TomJo2000
TomJo2000 approved these changes Oct 23, 2024
View reviewed changes
Copy link
Member

@TomJo2000 TomJo2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@TomJo2000 TomJo2000 merged commit ea62922 into termux:master Oct 23, 2024
6 checks passed
@xronin01
Copy link

Screenshot_20241023-184525_Termux_1
it's not working for me

@Mause
Copy link
Contributor Author

Mause commented Oct 24, 2024 •
edited
Loading

Screenshot_20241023-184525_Termux_1
it's not working for me

Looks like the override of Linux here doesn't work everywhere unfortunately

@Mause Mause deleted the uv-venv branch October 30, 2024 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@licy183 licy183 licy183 approved these changes

@TomJo2000 TomJo2000 TomJo2000 approved these changes

@twaik twaik twaik approved these changes

@finagolfin finagolfin Awaiting requested review from finagolfin

@Grimler91 Grimler91 Awaiting requested review from Grimler91 Grimler91 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Mause @xronin01 @twaik @TomJo2000 @licy183