Runtime fv

[aazhou1]

Summary by CodeRabbit

Release Notes

• New Features

  • Introduced a new StrategyState struct to encapsulate strategy parameters.
  • Added a public function getStrategyState to retrieve the current strategy state.

• Bug Fixes

  • Enhanced error handling with custom errors for auction and token validation.

• Refactor

  • Simplified parameter handling in strategy deployment and testing functions.
  • Updated access methods to retrieve strategy parameters through getStrategyState.

• Chores

  • Removed unnecessary input parameters from deployment workflows and strategy constructors.

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

The changes in this pull request involve the removal of two input parameters, collateralTokenAddress and minCollateralRatio, from the GitHub Actions workflow file and various smart contract files. This modification simplifies the parameter handling in the strategy deployment process across multiple contracts, including DeployStrategy, Strategy, and related test files. Additionally, several constants' visibility levels have been updated, and new error handling mechanisms have been introduced to enhance clarity and maintainability.

Changes

File Path	Change Summary
.github/workflows/deploy-sepolia-strategy.yaml	Removed input parameters collateralTokenAddress and minCollateralRatio from workflow_dispatch.
script/Strategy.s.sol	Removed initialization of collateralTokenAddr and minCollateralRatio arrays from buildStrategyParams.
src/RepoTokenList.sol	Changed visibility of NULL_NODE from public to internal; simplified getPresentValue and validateAndInsertRepoToken functions.
src/RepoTokenUtils.sol	Changed visibility of THREESIXTY_DAYCOUNT_SECONDS and RATE_PRECISION from public to internal.
src/Strategy.sol	Removed parameters from constructor; added StrategyState struct; introduced new custom errors; changed visibility of several state variables from public to internal.
src/TermAuctionList.sol	Changed visibility of NULL_NODE from public to internal; simplified logic in getPresentValue and getCumulativeOfferData.
src/test/TestUSDCIntegration.t.sol	Updated assertions to access discountRateAdapter through getStrategyState().
src/test/TestUSDCSellRepoToken.t.sol	Updated assertions for governance parameters to use getStrategyState().
src/test/utils/Setup.sol	Removed parameters collateralTokenAddr and minCollateralRatio from constructStrategy function.

Possibly related PRs

• Adding repo concentration limit #5: Involves removing minCollateralRatio and collateralTokenAddress from the RepoTokenList, aligning with the main PR's changes.
• Various strategy fixes #9: Removes the termController parameter from validateRepoToken, related to the simplification of parameter handling.
• Adding back concentration ratio #12: Addition of simulatedRepoTokenConcentrationRatio output in Strategy, relating to the main PR's focus on collateral parameters.
• remove collateral token ratio initialization #88: Directly addresses the removal of collateralTokenAddress and minCollateralRatio, indicating a strong connection to the main PR.

🐰 In a meadow where bunnies play,
We’ve tidied up our code today!
Removed some clutter, made it neat,
Now our strategies can’t be beat!
With clearer paths and fewer strings,
Hoppy coding, oh what joy it brings! 🌼

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.