Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stylebot] Fixes for code style #108

Merged
merged 1 commit into from
Dec 24, 2024
Merged

[stylebot] Fixes for code style #108

merged 1 commit into from
Dec 24, 2024

Conversation

term-stylebot[bot]
Copy link

@term-stylebot term-stylebot bot commented Dec 9, 2024

Stylebot detected automatically fix-able code style issues.

`yarn fix:eslint`
yarn run v1.22.22
$ solhint --fix 'src/**/*.sol'
Failed to load a solhint's config file.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
`yarn fix:prettier`
yarn run v1.22.22
$ prettier --write 'src/**/*.(sol|json)'
src/interfaces/IStrategyInterface.sol 62ms
src/interfaces/term/ITermAuction.sol 24ms
src/interfaces/term/ITermAuctionOfferLocker.sol 25ms
src/interfaces/term/ITermController.sol 7ms
src/interfaces/term/ITermDiscountRateAdapter.sol 10ms
src/interfaces/term/ITermRepoCollateralManager.sol 5ms
src/interfaces/term/ITermRepoServicer.sol 4ms
src/interfaces/term/ITermRepoToken.sol 5ms
src/interfaces/term/ITermVaultEvents.sol 22ms
src/RepoTokenList.sol 391ms
src/RepoTokenUtils.sol 50ms
src/Strategy.sol 392ms
src/TermAuctionList.sol 125ms
src/TermDiscountRateAdapter.sol 68ms
src/TermVaultEventEmitter.sol 30ms
src/test/FunctionSignature.t.sol 60ms
src/test/kontrol/Constants.sol 2ms
src/test/kontrol/Counterexamples.t.sol 24ms
src/test/kontrol/KontrolTest.sol 60ms
src/test/kontrol/RepoToken.sol 41ms
src/test/kontrol/RepoTokenListInvariants.t.sol 60ms
src/test/kontrol/RepoTokenListTest.t.sol 133ms
src/test/kontrol/TermAuction.sol 9ms
src/test/kontrol/TermAuctionListInvariants.t.sol 166ms
src/test/kontrol/TermAuctionListTest.t.sol 262ms
src/test/kontrol/TermAuctionOfferLocker.sol 33ms
src/test/kontrol/TermDiscountRateAdapter.sol 12ms
src/test/kontrol/TermRepoCollateralManager.sol 26ms
src/test/kontrol/TermRepoServicer.sol 8ms
src/test/mocks/MockFeesFactory.sol 4ms
src/test/mocks/MockTermAuction.sol 29ms
src/test/mocks/MockTermAuctionOfferLocker.sol 51ms
src/test/mocks/MockTermController.sol 13ms
src/test/mocks/MockTermRepoCollateralManager.sol 11ms
src/test/mocks/MockTermRepoLocker.sol 6ms
src/test/mocks/MockTermRepoServicer.sol 19ms
src/test/mocks/MockTermRepoToken.sol 17ms
src/test/mocks/MockUSDC.sol 3ms
src/test/Operation.t.sol 72ms
src/test/Shutdown.t.sol 13ms
src/test/TestUSDCIntegration.t.sol 235ms
src/test/TestUSDCOffers.t.sol 194ms
src/test/TestUSDCSellRepoToken.t.sol 320ms
src/test/TestUSDCSubmitOffer.t.sol 117ms
src/test/utils/ExtendedTest.sol 36ms
src/test/utils/Setup.sol 78ms
src/util/TermFinanceVaultWrappedVotesToken.sol 24ms
Done in 3.85s.

Copy link

coderabbitai bot commented Dec 9, 2024

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@term-stylebot term-stylebot bot force-pushed the stylebot/patch branch 3 times, most recently from 33f8379 to 68faaab Compare December 10, 2024 02:08
Copy link

codecov bot commented Dec 10, 2024

Codecov Report

Attention: Patch coverage is 85.18519% with 52 lines in your changes missing coverage. Please review.

Project coverage is 88.65%. Comparing base (0d163af) to head (33572e1).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/TermAuctionList.sol 82.67% 19 Missing and 3 partials ⚠️
src/RepoTokenList.sol 86.48% 19 Missing and 1 partial ⚠️
src/Strategy.sol 82.75% 7 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #108      +/-   ##
==========================================
- Coverage   88.90%   88.65%   -0.25%     
==========================================
  Files           5        5              
  Lines         604      626      +22     
  Branches       90       91       +1     
==========================================
+ Hits          537      555      +18     
- Misses         56       60       +4     
  Partials       11       11              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@term-stylebot term-stylebot bot force-pushed the stylebot/patch branch 12 times, most recently from 315b762 to 168086a Compare December 16, 2024 19:16
@term-stylebot term-stylebot bot force-pushed the stylebot/patch branch 13 times, most recently from 3760b70 to 9ab8370 Compare December 20, 2024 07:45
@term-stylebot term-stylebot bot force-pushed the stylebot/patch branch 26 times, most recently from e6b5728 to be7318a Compare December 23, 2024 20:47
@robotoer robotoer merged commit c73958f into master Dec 24, 2024
2 of 4 checks passed
@robotoer robotoer deleted the stylebot/patch branch December 24, 2024 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants