Skip to content

Commit

Permalink
governance added to deploy script
Browse files Browse the repository at this point in the history
  • Loading branch information
aazhou1 committed Nov 18, 2024
1 parent af79fe3 commit 991636d
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 2 deletions.
6 changes: 5 additions & 1 deletion .github/workflows/deploy-sepolia-strategy.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,10 @@ on:
description: 'Yearn strategy name'
required: true
default: '0x'
governorRoleAddress:
description: 'Governor role address'
required: true
default: '0x'
discountRateMarkup:
description: 'Discount rate markup'
required: false
Expand Down Expand Up @@ -58,7 +62,7 @@ jobs:
REPOTOKEN_CONCENTRATION_LIMIT: ${{ github.event.inputs.repoTokenConcentrationLimit }}
ADMIN_ADDRESS: ${{ vars.ADMIN_ADDRESS }}
DEVOPS_ADDRESS: ${{ vars.DEVOPS_ADDRESS }}
GOVERNOR_ROLE_ADDRESS: ${{ vars.GOVERNANCE_FACTORY }}
GOVERNOR_ROLE_ADDRESS: ${{ github.event.inputs.governorRoleAddress }}
STRATEGY_MANAGEMENT_ADDRESS: ${{ vars.GOVERNANCE_FACTORY }}
NEW_REQUIRED_RESERVE_RATIO: ${{ github.event.inputs.requiredReserveRatio }}

2 changes: 1 addition & 1 deletion script/Strategy.s.sol
Original file line number Diff line number Diff line change
Expand Up @@ -137,6 +137,7 @@ contract DeployStrategy is Script {
// Retrieve environment variables
string memory name = vm.envString("STRATEGY_NAME");
address strategyManagement = vm.envAddress("STRATEGY_MANAGEMENT_ADDRESS");
address newGovernor = vm.envAddress("NEW_GOVERNOR");
bool isTest = vm.envBool("IS_TEST");


Expand All @@ -156,7 +157,6 @@ contract DeployStrategy is Script {
console.log("set pending management");
console.log(strategyManagement);


if (isTest) {
eventEmitter.pairVaultContract(address(strategy));
console.log("paired strategy contract with event emitter");
Expand Down

0 comments on commit 991636d

Please sign in to comment.