-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
certora updates #17
Merged
Merged
certora updates #17
Changes from 41 commits
Commits
Show all changes
47 commits
Select commit
Hold shift + click to select a range
719007c
certora updates
aazhou1 8acea29
ignore solidity warnings in servicer
aazhou1 23c8fea
ignore solidity warnings rollover manager
aazhou1 d1832fd
replace newSplitParallel certora config proverarg
aazhou1 0bdb54d
get rid of branch versions of certora
aazhou1 15871d7
replace newSplitParallel certora config proverarg
aazhou1 3e15dce
update access roles test for servicer with new controller function fo…
aazhou1 793cd2b
remove extra semicolon
aazhou1 cd55e0f
remove specialist role from servicer specs certora
aazhou1 d148d86
link controller to servicer in servicer spec for certora
aazhou1 fa90c26
prevent previous term locker from conflicting with controller treasur…
aazhou1 4621474
add envfree declaration of get treasury address to rollover exposure …
aazhou1 42a611e
no zero address msg sender in exposure opening on new rollover certora
aazhou1 4faeef2
treasuery cannot be borrow address
aazhou1 9bb3594
treasuery cannot be borrow address
aazhou1 4838471
treasuery address always 100
aazhou1 8468755
treasuery address always 100
aazhou1 7da828e
100 address for treasury imported from rules for servicer
aazhou1 3a42c44
100 address for treasury imported from rules for servicer
aazhou1 a7943dd
100 address for treasury imported from rules for servicer
aazhou1 d1e24e1
controller harness for certora
aazhou1 38073be
controller harness for certora
aazhou1 8937188
fix acccess roles for servicer certora spec
aazhou1 36af4cb
100 address for treasury imported from rules for servicer
aazhou1 3488644
100 address for treasury imported from rules for servicer
aazhou1 d9e997a
further split tests
aazhou1 7950d57
undo servicer update
aazhou1 726543b
minting changes certora spec
aazhou1 00723b0
minting changes certora spec
aazhou1 d9ba8a5
beta cli runs for errors in certora prod
aazhou1 5cce3b4
add 2 new reverts for repayments in certora
aazhou1 aa7ce02
NONDET summary for access roles controller call for mint open exposur…
aazhou1 78040d3
split repay and redemption revert certora specs
aazhou1 47592d6
add semicolon to end of summary in access roles servicer certora
aazhou1 a08d26e
ignore solidity warnings certora
aazhou1 c38a54d
split repay and redemption revert certora specs
aazhou1 04460ac
verify mint exposure access methods certora
aazhou1 246506f
add env to verifyMintExposureAccess calls
aazhou1 c2e66c6
DISPATCHER true verifyMintExposureAccess
aazhou1 660f315
trying to get linking to work
aazhou1 0bdb6ab
trying to get linking to work
aazhou1 5df7c54
trying to get linking to work
aazhou1 46741e8
trying to get linking to work
aazhou1 743973f
redemption reverts branch version removed
aazhou1 7a5b2d3
redemption reverts branch version removed
aazhou1 335b4f3
redemption reverts branch version removed
aazhou1 ccb2ae4
get mint integrity to stop timing out
aazhou1 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,41 @@ | ||
| { | ||
| "files": [ | ||
| "certora/harness/TermRepoServicerHarness.sol", | ||
| "contracts/TermAuctionBidLocker.sol", | ||
| "contracts/TermController.sol", | ||
| "contracts/TermRepoLocker.sol", | ||
| "contracts/TermRepoToken.sol", | ||
| "contracts/TermRepoRolloverManager.sol", | ||
| "certora/harness/TermRepoCollateralManagerHarness.sol", | ||
| "certora/helpers/DummyERC20A.sol" | ||
| ], | ||
| "link": [ | ||
| "TermRepoServicerHarness:termRepoToken=TermRepoToken", | ||
| "TermRepoServicerHarness:termRepoLocker=TermRepoLocker", | ||
| "TermRepoServicerHarness:termRepoCollateralManager=TermRepoCollateralManagerHarness", | ||
| "TermRepoServicerHarness:termRepoRolloverManager=TermRepoRolloverManager", | ||
| "TermRepoCollateralManagerHarness:termRepoLocker=TermRepoLocker" | ||
| ], | ||
| "prover_args": [ | ||
| "-smt_initialSplitDepth 5", | ||
| "-depth 15", | ||
| "-mediumTimeout 2", | ||
| "-splitParallel true", | ||
| "-splitParallelTimelimit 7200", | ||
| "-splitParallelInitialDepth 5" | ||
| ], | ||
| "solc_optimize": "50", | ||
| "loop_iter": "2", | ||
| "optimistic_loop": true, | ||
| "ignore_solidity_warnings": true, | ||
| "smt_timeout": "7200", | ||
| "parametric_contracts": [ | ||
| "TermRepoServicerHarness" | ||
| ], | ||
| "rule_sanity": "basic", | ||
| "packages": [ | ||
| "@chainlink=node_modules/@chainlink", | ||
| "@openzeppelin=node_modules/@openzeppelin" | ||
| ], | ||
| "verify": "TermRepoServicerHarness:certora/specs/termRepoServicer/rulesMintIntegrity.spec" | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,41 @@ | ||
| { | ||
| "files": [ | ||
| "certora/harness/TermRepoServicerHarness.sol", | ||
| "contracts/TermAuctionBidLocker.sol", | ||
| "contracts/TermController.sol", | ||
| "contracts/TermRepoLocker.sol", | ||
| "contracts/TermRepoToken.sol", | ||
| "contracts/TermRepoRolloverManager.sol", | ||
| "certora/harness/TermRepoCollateralManagerHarness.sol", | ||
| "certora/helpers/DummyERC20A.sol" | ||
| ], | ||
| "link": [ | ||
| "TermRepoServicerHarness:termRepoToken=TermRepoToken", | ||
| "TermRepoServicerHarness:termRepoLocker=TermRepoLocker", | ||
| "TermRepoServicerHarness:termRepoCollateralManager=TermRepoCollateralManagerHarness", | ||
| "TermRepoServicerHarness:termRepoRolloverManager=TermRepoRolloverManager", | ||
| "TermRepoCollateralManagerHarness:termRepoLocker=TermRepoLocker" | ||
| ], | ||
| "prover_args": [ | ||
| "-smt_initialSplitDepth 5", | ||
| "-depth 17", | ||
| "-mediumTimeout 2", | ||
| "-splitParallel true", | ||
| "-splitParallelTimelimit 7200", | ||
| "-splitParallelInitialDepth 5" | ||
| ], | ||
| "solc_optimize": "50", | ||
| "ignore_solidity_warnings": true, | ||
| "loop_iter": "2", | ||
| "optimistic_loop": true, | ||
| "smt_timeout": "7200", | ||
| "parametric_contracts": [ | ||
| "TermRepoServicerHarness" | ||
| ], | ||
| "rule_sanity": "basic", | ||
| "packages": [ | ||
| "@chainlink=node_modules/@chainlink", | ||
| "@openzeppelin=node_modules/@openzeppelin" | ||
| ], | ||
| "verify": "TermRepoServicerHarness:certora/specs/termRepoServicer/rulesRepaymentsReverts.spec" | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,42 @@ | ||
| { | ||
| "files": [ | ||
| "certora/harness/TermRepoServicerHarness.sol", | ||
| "contracts/TermAuctionBidLocker.sol", | ||
| "contracts/TermController.sol", | ||
| "contracts/TermRepoLocker.sol", | ||
| "contracts/TermRepoToken.sol", | ||
| "contracts/TermRepoRolloverManager.sol", | ||
| "certora/harness/TermRepoCollateralManagerHarness.sol", | ||
| "certora/helpers/DummyERC20A.sol" | ||
| ], | ||
| "link": [ | ||
| "TermRepoServicerHarness:termRepoToken=TermRepoToken", | ||
| "TermRepoServicerHarness:termRepoLocker=TermRepoLocker", | ||
| "TermRepoServicerHarness:termRepoCollateralManager=TermRepoCollateralManagerHarness", | ||
| "TermRepoServicerHarness:termController=TermController", | ||
| "TermRepoServicerHarness:termRepoRolloverManager=TermRepoRolloverManager", | ||
| "TermRepoCollateralManagerHarness:termRepoLocker=TermRepoLocker" | ||
| ], | ||
| "prover_args": [ | ||
| "-smt_initialSplitDepth 10", | ||
| "-depth 20", | ||
| "-mediumTimeout 2", | ||
| "-splitParallel true", | ||
| "-splitParallelTimelimit 7200", | ||
| "-splitParallelInitialDepth 10" | ||
| ], | ||
| "solc_optimize": "50", | ||
| "loop_iter": "2", | ||
| "optimistic_loop": true, | ||
| "ignore_solidity_warnings": true, | ||
| "smt_timeout": "7200", | ||
| "parametric_contracts": [ | ||
| "TermRepoServicerHarness" | ||
| ], | ||
| "rule_sanity": "basic", | ||
| "packages": [ | ||
| "@chainlink=node_modules/@chainlink", | ||
| "@openzeppelin=node_modules/@openzeppelin" | ||
| ], | ||
| "verify": "TermRepoServicerHarness:certora/specs/termRepoServicer/rulesRolloverReverts.spec" | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider the implications of ignoring all Solidity warnings.
Ignoring all Solidity warnings (
ignore_solidity_warnings: true) may lead to overlooking significant issues in smart contracts, especially in a production environment. It's crucial to weigh the benefits against potential risks. If this setting is necessary for certain builds or testing scenarios, consider enabling it conditionally or ensuring that all warnings are reviewed manually or through additional automated checks before deployment.