Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

138 fix project bootstraping #145

Merged
merged 37 commits into from
Jan 31, 2024
Merged

138 fix project bootstraping #145

merged 37 commits into from
Jan 31, 2024

Conversation

wazolab
Copy link
Member

@wazolab wazolab commented Jan 19, 2024

  • Setup Stylelint
  • Setup Eslint
  • Remove unused dependecies
  • Fix yarn scripts

⚠️ Dependency incompatibility
"nuxt": "^3.2.3" isn't compatible with "nuxt-simple-sitemap": "^2.7.0" it only works in our environment because we aren't adding nuxt-simple-sitemap to modules which is a bad practice.

@wazolab wazolab requested a review from frodrigo January 19, 2024 01:52
@wazolab wazolab force-pushed the 138-fix-project-bootstraping branch 3 times, most recently from d2ed9a3 to a493506 Compare January 29, 2024 13:57
@wazolab wazolab marked this pull request as ready for review January 29, 2024 14:57
@wazolab wazolab force-pushed the 138-fix-project-bootstraping branch from 142257e to 310df22 Compare January 30, 2024 15:28
@wazolab
Copy link
Member Author

wazolab commented Jan 30, 2024

@frodrigo PR is ready to be reviewed

@frodrigo frodrigo force-pushed the 138-fix-project-bootstraping branch from cabbdd8 to 42d171c Compare January 31, 2024 08:35
@wazolab wazolab force-pushed the 138-fix-project-bootstraping branch from 42d171c to aff616a Compare January 31, 2024 09:21
@wazolab wazolab force-pushed the 138-fix-project-bootstraping branch from aff616a to eeac0ea Compare January 31, 2024 09:33
@frodrigo frodrigo merged commit 5fabc93 into develop Jan 31, 2024
5 checks passed
@wazolab wazolab deleted the 138-fix-project-bootstraping branch April 9, 2024 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants