-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
State and prove Theorem 2.36 #202
Conversation
@jscanvic : since this is a draft PR, GitHub won't automatically show this, but an upstream PR might have introduced merge conflicts due to the notation change for Magma. Could you check if merging the main branch into your branch works? |
@Shreyas4991 It appears to be working after changing the notation. |
The PR is marked as a draft. The CI will automatically run when the PR is not a draft anymore. I have manually run it for now. |
awaiting-review |
Uhm apparently the build fails due to 4 newly added theorems in |
is the new equation 23893 a completely different equation from the previous one. If so, how does giving it a different number and retaining the old equation 23893 affect this PR? |
The two equations are indeed completely different. As far as I can tell, giving the new one a new number would simply require changing it in the blueprint |
Then this would be the path of least resistance. I would recommend it. |
Alright! I've made the changes from |
Actually the equation |
My bad. I wasn't aware of the extended numbering. It should be good now! |
Small blueprint issue - one of the references to 28393 in the blueprint now has to be renumbered. Sorry, that should be the last thing and then we can merge! |
Done! |
Closes #374 * Introduce and prove `Finite.two_variable_laws` formalizing Theorem 3.11 * Add `\leanok` and the reference of the theorem in the blueprint * Add missing `\leanok` and reference of another theorem in the blueprint (#202) Note: the proof is that of Austin (1966) --------- Co-authored-by: Pietro Monticone <[email protected]>
Finite.Equation28394_implies_Equation2
andEquation28394_not_implies_Equation2
closing INFINITE: State and prove Theorem 2.36 (second Kisielewicz law) of the blueprint in Lean. #125.