[Bugfix] #31 _make_sampler_output return expected SequenceOutput output_token: int #32
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
change log
summary
_make_sampler_output makes sense to do the conversion because input (cached_step_outputs) is expected to be List[torch.Tensor] so further upstream would require other changes.
vllm/vllm/worker/tt_model_runner.py::TTModelRunner::_make_sampler_output -> SamplerOutput
vllm/vllm/model_executor/layers/sampler.py::SamplerOutput
vllm/vllm/sequence.py::CompletionSequenceGroupOutput
vllm/vllm/sequence.py::SequenceOutput