Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bugfix] #31 _make_sampler_output return expected SequenceOutput output_token: int #32

Merged
merged 1 commit into from
Oct 31, 2024

Conversation

tstescoTT
Copy link

change log

summary

_make_sampler_output makes sense to do the conversion because input (cached_step_outputs) is expected to be List[torch.Tensor] so further upstream would require other changes.

vllm/vllm/worker/tt_model_runner.py::TTModelRunner::_make_sampler_output -> SamplerOutput

vllm/vllm/model_executor/layers/sampler.py::SamplerOutput

outputs: List[CompletionSequenceGroupOutput]

vllm/vllm/sequence.py::CompletionSequenceGroupOutput

samples: List[SequenceOutput]

vllm/vllm/sequence.py::SequenceOutput

output_token: int

…Runner::_make_sampler_output as expected by vLLM downstream
Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

@skhorasganiTT skhorasganiTT self-requested a review October 31, 2024 14:55
@tstescoTT tstescoTT merged commit 54b9157 into dev Oct 31, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants