Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#86: Remove ARCH_NAME dependency for libdevice.so #87

Merged
merged 3 commits into from
Sep 27, 2024
Merged

#86: Remove ARCH_NAME dependency for libdevice.so #87

merged 3 commits into from
Sep 27, 2024

Conversation

blozano-tt
Copy link
Collaborator

@blozano-tt blozano-tt commented Sep 27, 2024 •
edited
Loading

Closes #86

Updated CI workflows to pass -DTT_UMD_BUILD_TESTS=ON

@blozano-tt
Copy link
Collaborator Author

Failing test does not seem related to the changes here.

@blozano-tt blozano-tt mentioned this pull request Sep 27, 2024
Open
joelsmithTT
joelsmithTT approved these changes Sep 27, 2024
View reviewed changes
Copy link
Contributor

@joelsmithTT joelsmithTT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable to me.

broskoTT
broskoTT reviewed Sep 27, 2024
View reviewed changes
CMakeLists.txt Outdated Show resolved Hide resolved
broskoTT
broskoTT approved these changes Sep 27, 2024
View reviewed changes
Copy link
Contributor

@broskoTT broskoTT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd do more changes with the CI .ymls (to reflect that ARCH_NAME is not needed now for building UMD without unit tests), but you don't have to in the current PR, I can do it afterwards.

@blozano-tt
Copy link
Collaborator Author

I think this PR is ready for merge, it is approved, but I can't merge it

@blozano-tt blozano-tt merged commit 22e054f into main Sep 27, 2024
11 of 12 checks passed
@blozano-tt blozano-tt deleted the blozano/cmake_adjustment branch September 27, 2024 22:59
@broskoTT broskoTT linked an issue Sep 28, 2024 that may be closed by this pull request
Remove conditional compilation #51
Closed
@broskoTT broskoTT mentioned this pull request Sep 30, 2024
Merged
broskoTT added a commit that referenced this pull request Sep 30, 2024
@broskoTT
No ARCH_NAME in CI building umd_device (#88)
60d54de 
A continuation to #87 , to reflect the current state in our CI.
Related to #86 and a part of #51 .

There is now enough difference between building umd_device and umd_tests
to warrant separate files, since umd_tests still requires ARCH_NAME and
umd_device does not. This way it looks clearer.
@broskoTT broskoTT linked an issue Oct 1, 2024 that may be closed by this pull request
Work on adding CI to umd repo #45
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@broskoTT broskoTT broskoTT approved these changes

@joelsmithTT joelsmithTT joelsmithTT approved these changes

@vtangTT vtangTT Awaiting requested review from vtangTT

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@blozano-tt @joelsmithTT @broskoTT