Remove RD/WR device/sysmem API with vector argument #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
broskoTT
reviewed
Sep 23, 2024
pjanevskiTT
force-pushed
the
pjanevski/device_wr_api
branch
from
77ca719 to
f12b194
Compare
broskoTT
approved these changes
Sep 24, 2024
pjanevskiTT
force-pushed
the
pjanevski/device_wr_api
branch
5 times, most recently
from
406f457 to
180b48b
Compare
broskoTT
force-pushed
the
pjanevski/device_wr_api
branch
from
180b48b to
028fd50
Compare
|
@joelsmithTT take a look if you can/want, it is ready to merge |
joelsmithTT
reviewed
Sep 30, 2024
joelsmithTT
approved these changes
Sep 30, 2024
pjanevskiTT
force-pushed
the
pjanevski/device_wr_api
branch
from
028fd50 to
8234631
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #67
Remove API for read and write to device/sysmem which has
std::vectoras an argument. Use only functions that havevoid*as an argument. Change calls insidett_silicon_driverwhich were usingstd::vectorvariantTODO
std::vectorarguement. Change this if needed before bumping UMD -> tt-metal was just usingvoid*interface