Replace snprintf and string concat with fmt::format #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pjanevskiTT
force-pushed
the
pjanevskiTT/string_formatting
branch
from
df3365e to
02b2624
Compare
joelsmithTT
reviewed
Sep 19, 2024
pjanevskiTT
force-pushed
the
pjanevskiTT/string_formatting
branch
3 times, most recently
from
b904b4a to
7872940
Compare
joelsmithTT
approved these changes
Sep 30, 2024
pjanevskiTT
force-pushed
the
pjanevskiTT/string_formatting
branch
from
7872940 to
9ba897c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #54
Note
hwlocobject hassnprintffunction for that specific type, which is builtin, so that is not changed in the PR