Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Harvesting] simulated_harvesting_masks passed to tt_SocDescriptor #440

Merged
merged 8 commits into from
Jan 3, 2025

Conversation

broskoTT
Copy link
Contributor

@broskoTT broskoTT commented Dec 26, 2024

Issue

Related to #439

Description

First of the changes preparing removal of harvesting logic inside Cluster.
perform_harvesting, and simulated_harvesting_masks arguments are now added to affect tt_SocDescriptor.
Had to remove logic converting harvesting_mask from physical layout coords to logical coords out of the CoordinateManager constructor.

List of the changes

  • perform_harvesting now affects harvesting in tt_SocDescriptor
  • simulated_harvesting_masks are now used for harvesting in tt_SocDescriptor
  • get_tensix_harvesting_mask is a helper function which does both of these
  • shuffle_tensix_harvesting_mask is now a static public function, which should be called prior to calling CoordinateManager
  • CoordinateManager now accepts harvesting in logical coords.
  • Due to deprecated get_harvesting_masks_for_soc_descriptors, there is an additional shuffle_tensix_harvesting_mask_to_noc0_coords which does the required translation.
  • tt_SocDescriptor removed copy constructor, since it is already a default one.
  • Other functions changed accordingly to pass this arguments

Testing

  • Changed call to get_harvesting_masks_for_soc_descriptors, so it is tested with the new flow, through harvesting provided by socdescriptor class
  • Added HarvestingShuffle tests in all arch tests

API Changes

There are no API changes in this PR.

@broskoTT broskoTT requested a review from pjanevskiTT December 26, 2024 10:12
device/cluster.cpp Show resolved Hide resolved
device/cluster.cpp Show resolved Hide resolved
device/cluster.cpp Show resolved Hide resolved
@broskoTT broskoTT mentioned this pull request Dec 27, 2024
2 tasks
@broskoTT broskoTT changed the title Remove harvesting from Cluster v1 [Harvesting] simulated_harvesting_masks passed to tt_SocDescriptor Dec 27, 2024
@broskoTT broskoTT enabled auto-merge (squash) January 3, 2025 10:24
@broskoTT broskoTT merged commit e13960a into main Jan 3, 2025
16 of 19 checks passed
@broskoTT broskoTT deleted the brosko/harvest_1 branch January 3, 2025 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants