Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle Blackhole board types #437

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

pjanevskiTT
Copy link
Contributor

Issue

#279
#433

Description

Handle Blackhole board types properly. Based on board type and chip chip NOC layout is different. This PR adds necessary soc descriptors and additional logic to handle everything through all UMD paths and structures.

List of the changes

  • Add soc descriptor for P150 chip (same as P300 local chip)
  • Add soc descriptor for P300 remote chip
  • Add utility functions to get proper soc descriptor
  • Fix other failing Blackhole unit tests

Testing

CI

API Changes

/

@pjanevskiTT pjanevskiTT self-assigned this Dec 25, 2024
@pjanevskiTT
Copy link
Contributor Author

@joelsmithTT can you check that tests from #434 are passing now, just to double check. Everything seems fine on my side

@pjanevskiTT pjanevskiTT force-pushed the pjanevski/blackhole_p150 branch 3 times, most recently from 5526682 to db7d6f1 Compare December 26, 2024 12:28
@pjanevskiTT pjanevskiTT force-pushed the pjanevski/blackhole_p150 branch from db7d6f1 to b759bcc Compare December 26, 2024 12:48
device/blackhole/blackhole_implementation.cpp Outdated Show resolved Hide resolved
device/blackhole/blackhole_implementation.cpp Show resolved Hide resolved
device/coordinate_manager.cpp Show resolved Hide resolved
device/blackhole/blackhole_implementation.cpp Show resolved Hide resolved
device/coordinate_manager.cpp Show resolved Hide resolved
device/tt_soc_descriptor.cpp Show resolved Hide resolved
device/api/umd/device/coordinate_manager.h Show resolved Hide resolved
@pjanevskiTT pjanevskiTT force-pushed the pjanevski/blackhole_p150 branch from 6487de1 to a831c65 Compare December 26, 2024 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants