Remove describe_tlb function #419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
broskoTT
force-pushed
the
brosko/tlb_data
branch
from
3779e26 to
8986d83
Compare
pjanevskiTT
approved these changes
Dec 20, 2024
There was a problem hiding this comment.
Nice changes. Left a few nit comments. In general, I think we should start writing tests for TLB configs, to be sure that we hit the address that we want or index if we care for the index. Not sure what is the right path here since maybe we don't want to expose BAR0 space, but we can think about it, maybe you can just open the follow up issue to have this on the radar
broskoTT
force-pushed
the
brosko/tlb_data
branch
from
5074ad8 to
b535c5a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Related to #417
Description
Seems like we've had a redundant get_tlb_configuration and describe_tlb functions. I also noted that sometimes we downcasted 64bit address to 32bit, so this should solve those problems if they were even present.
List of the changes
Testing
Existing CI tests
API Changes
This PR has API changes. I've left old API in place so that this change is not breaking, but is marked as deprecated.